Fix devnet2 finalization issues#74
Merged
ArtiomTr merged 1 commit intograndinetech:mainfrom Feb 12, 2026
Merged
Conversation
ArtiomTr
force-pushed
the
fix/proposer-signature
branch
from
76dabe0 to
ab1427c
Compare
Fixed few finalization issues, encountered in devnet-2: * Invalid proposer signature - this was due to invalid signature SSZ representation - previously it was a byte list inside container, now it is just a byte list. * Unknown block errors - p2p limits weren't configured properly, and with addition of aggregated signatures (which can be up to 1mb), messages with blocks weren't received. * Finalization issues - validator public key was in invalid format, similar to proposer signature error. Overall this not only fixes all finalization issues related to devnet-2, but also state transition code was refactored a bit to be more similar to spec.
ArtiomTr
force-pushed
the
fix/proposer-signature
branch
from
ab1427c to
b3aed1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed few finalization issues, encountered in devnet-2:
Overall this not only fixes all finalization issues related to devnet-2, but also state transition code was refactored a bit to be more similar to spec.