Skip to content

Conversation

@kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Jan 17, 2026

Also update some tangentially-related TODOs.

Tested by trying webgpu:api,validation,capability_checks,limits,maxBindGroups:setBindGroup,at_over:* in Chrome which doesn't expose a higher value for maxBindGroups.

Issue: part of #4561


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [n/a] Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • [n/a] Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x requested a review from greggman January 17, 2026 00:35
@github-actions
Copy link

github-actions bot commented Jan 17, 2026

Results for build job (at 0713ad4):

 Test case/subcase counts did not change.

@kainino0x kainino0x enabled auto-merge (squash) January 17, 2026 08:09
@kainino0x kainino0x merged commit 4be9112 into gpuweb:main Jan 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants