-
Notifications
You must be signed in to change notification settings - Fork 35
chore(deps): update dependency pry-byebug to "~> 3.12.0" #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the pry-byebug dependency to version ~> 3.12.0. This update introduces a critical compatibility issue, as the new version of pry-byebug drops support for Ruby 3.1, while this project still officially supports it according to the .gemspec file. This would break the development environment for anyone using Ruby 3.1. I have added a comment recommending that this change be reverted to maintain compatibility.
| gem "minitest-rg", "~> 5.3.0" | ||
| gem "pry", "~> 0.14.2" | ||
| gem "pry-byebug", "~> 3.11.0" | ||
| gem "pry-byebug", "~> 3.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to pry-byebug v3.12.0 introduces a critical compatibility issue. The release notes for this version state that support for Ruby 3.1 has been dropped. However, the project's activerecord-spanner-adapter.gemspec file still lists Ruby 3.1 as a supported version (required_ruby_version = ">= 3.1").
This will break the development environment for anyone using Ruby 3.1, as bundle install will fail. To maintain compatibility, please revert this change. If dropping Ruby 3.1 support is intended, it should be done as a separate, deliberate change that also updates the .gemspec.
gem "pry-byebug", "~> 3.11.0"
This PR contains the following updates:
"~> 3.11.0"→"~> 3.12.0"Release Notes
deivid-rodriguez/pry-byebug (pry-byebug)
v3.12.0Compare Source
Added
Removed
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.