ENH: slightly prefer split before named assigns#692
Draft
apbard wants to merge 1 commit intogoogle:mainfrom
Draft
ENH: slightly prefer split before named assigns#692apbard wants to merge 1 commit intogoogle:mainfrom
apbard wants to merge 1 commit intogoogle:mainfrom
Conversation
Member
|
Look around |
Contributor
Author
|
I am not sure we can do that there. Because ideally what we would like to achieve is something like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up #691, this is an attempt to fix it by slightly favour split before named assign.
In the current state it only mitigates the effect in some cases:
Also it breaks a couple of tests that are right the way they are now. Example:
@gwelymernans Any idea where/how to fix this?