Add an explicit flush and close before os.rename to fix EOFError: Ran out of input#1263
Add an explicit flush and close before os.rename to fix EOFError: Ran out of input#1263anmyachev wants to merge 1 commit intogoogle:mainfrom
flush and close before os.rename to fix EOFError: Ran out of input#1263Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @bwendling!
Hi @hartwork, maybe you can review too. |
|
My team recently had to upgrade yapf to get python 3.13 compatibility, and we're now seeing this issue once or twice per week. We aren't using especially high-end build nodes (16 cpu, 32GB RAM), and we're not an especially large team. We're going to try switching to the forked version with this fix, but it seems like this issue might be widespread. |
Even with this fix: #1243
EOFError: Ran out of inputerror is observed when usingyapfwithpre-commiton powerful multi-core systems.Before I suggest this change to you, I tested it in our repository using a fork: intel/intel-xpu-backend-for-triton#3324. For 5 days now I have not seen the error again, which gives me confidence to say that the change at least reduces the frequency of this problem, and at most solves it completely.
Hi @bwendling, could you review this change?