Allow joining of case statements in line_joiner.py#1211
Open
MarcelSimader wants to merge 1 commit intogoogle:mainfrom
Open
Allow joining of case statements in line_joiner.py#1211MarcelSimader wants to merge 1 commit intogoogle:mainfrom
line_joiner.py#1211MarcelSimader wants to merge 1 commit intogoogle:mainfrom
Conversation
Allows for the same rules that govern if-then statements to be applied to simple case statements.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for the same joining rules that govern if-then statements to be applied to simple case statements.
Examples
This will allow the common (at least in C switch-case blocks, from my experience) idiom of converting if-else-if chains into simple match-case statements, e.g.:
Without the proposed changes, the block above would be formatted like this:
This is my first time contributing to any open source project, so bear with me. Thanks!