Improve local development workflow/instructions#165
Merged
nsalminen merged 4 commits intogoogle:mainfrom Feb 14, 2026
Merged
Conversation
dli7319
approved these changes
Feb 13, 2026
package.json
Outdated
| "dev": "concurrently \"npm:build:watch\" \"npm:serve\"", | ||
| "start": "npm run dev", | ||
| "build:watch": "rollup -c -w", | ||
| "serve": "http-server --cors -p 8080", |
Collaborator
There was a problem hiding this comment.
Could you also add -a 127.0.0.1 so it's not listening any actual network interfaces?
Collaborator
Author
|
Will wait for @ruofeidu's review before merging for an extra check as it changes the main README and dev workflow. |
This can be removed as 'npm install' already calls the build step automatically in 'prepare'
ruofeidu
approved these changes
Feb 14, 2026
Collaborator
|
Thank you Nels! LGTM! -- I still owe you 3DGS asset --- will try getting done by next week :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo documentation contains some inconsistent instructions for running samples/demos and local development. Different READMEs reference different commands, including outdated ones like
develop.sh. It is also not fully clear when to use a one-time build and serve workflow vs. watch-mode development.This PR adds scripts for local development, introduces
http-serveras a development dependency, and aligns the README instructions.npm run devis introduced as a new command to run both the new commandsbuild:watchandserve. It also proposes makingnpm startan alias ofnpm run dev, as is common for SDKs, rather than limiting it to runningrollupin watch mode.I'm open to suggestions on how to improve this PR!