Refactor XR Keyboard layout and UI rendering#156
Open
jolicaD wants to merge 5 commits intogoogle:mainfrom
Open
Refactor XR Keyboard layout and UI rendering#156jolicaD wants to merge 5 commits intogoogle:mainfrom
jolicaD wants to merge 5 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Thank you Jolica! Would you Gemini solutions to update branch, sign CLA, and pass all prechecks? Thanks! |
dli7319
reviewed
Feb 9, 2026
| this.keyboard = new Keyboard(); | ||
| this.add(this.keyboard); | ||
| this.keyboard.position.set(0, -0.3, 0); | ||
| this.keyboard.position.set(0, -0.3, -0.); |
| try { | ||
| z = zFunction(x, y); | ||
| // Clamp the value to stay between -Z_LIMIT and Z_LIMIT | ||
| z = Math.max(-Z_LIMIT, Math.min(Z_LIMIT, z)); |
Collaborator
There was a problem hiding this comment.
xb.clamp(-Z_LIMIT, Z_LIMIT, z)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Keyboard Layout & Rendering Engine
This PR modernizes the virtual keyboard by refactoring the layout logic and improving render stability in XR.
Key Changes
Unified Layout Engine: Replaced manual weight calculations with a consolidated addKey method and constant-driven spacing (COL_SPACER, ROW_SPACER).
Improved Depth Management: Added a recursive applyZOrder function to ensure all keyboard sub-elements render correctly on top of other world objects.
Visual Polish: Switched to a borderless shader and updated the color palette for better legibility.