Skip to content

optimize the performance (fps) of mesh detector in xrblocks#144

Open
JFGVL1187 wants to merge 1 commit intogoogle:mainfrom
JFGVL1187:webxr-mesh-support
Open

optimize the performance (fps) of mesh detector in xrblocks#144
JFGVL1187 wants to merge 1 commit intogoogle:mainfrom
JFGVL1187:webxr-mesh-support

Conversation

@JFGVL1187
Copy link
Collaborator

For work collaboration, not for merge yet.

@JFGVL1187 JFGVL1187 requested a review from dli7319 February 4, 2026 22:23
@dli7319
Copy link
Collaborator

dli7319 commented Feb 4, 2026

I'd prefer to hold off on this change until your Chromium CL is submitted.

When we're not rendering anything, we should still be able to get 72 fps on Galaxy XR but it's not the case yet.

@JFGVL1187
Copy link
Collaborator Author

No Problem. I published this PR so that you can also fetch it and try other optimization methods, e.g. batch rendering if needed.

@ruofeidu
Copy link
Collaborator

ruofeidu commented Feb 4, 2026

also do an npm run format :)

@JFGVL1187 JFGVL1187 force-pushed the webxr-mesh-support branch 3 times, most recently from 38a7a31 to 6cb5dad Compare February 5, 2026 00:03
@dli7319 dli7319 removed their request for review February 5, 2026 00:03
}
}

dispose() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@JFGVL1187 JFGVL1187 force-pushed the webxr-mesh-support branch 2 times, most recently from d6e9303 to 60ff834 Compare February 16, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants