properly attach '.woff2' to filenames without suffix#97
properly attach '.woff2' to filenames without suffix#97rcanavan wants to merge 1 commit intogoogle:masterfrom
Conversation
…lename in woff2_info
|
Updated the patch to include woff2_decode and woff2_info. This should fix #79 |
|
The right solution is probably to take --in --out on the CLI. From a glance at the diff I imagine this is broken on Windows still. Instead of worrying about paths I suggest just setting |
That's actually what we were using for about a year, since it's predictable for use in scripts. I've chosen this solution because it produces "prettier" results... |
|
Having an |
|
Or even simply making the second argument (if provided) the output file name, so one can just say |
|
I prefer --out (w/default sgtm) because that makes it easy to add more, e.g. |
the output filename is incorrectly assembled if the input filename for woff2_compress only contains dots in the path component. Example:
$ woff2_compress /tmp/foo.bar/baz Processing /tmp/foo.bar/baz => /tmp/foo.woff2This simple patch produces the desired output file:
Processing /tmp/foo.bar/baz => /tmp/foo.bar/baz.woff2