cmake: Introduce a INSTALL_TOOLS build option#101
Open
aperezdc wants to merge 1 commit intogoogle:masterfrom
Open
cmake: Introduce a INSTALL_TOOLS build option#101aperezdc wants to merge 1 commit intogoogle:masterfrom
aperezdc wants to merge 1 commit intogoogle:masterfrom
Conversation
Packagers and distributors which use the CMake-based build system may
want to install the woff2_{decompress,compress,info} tools as well when
building shared libraries. Using "cmake -DINSTALL_TOOLS=ON" allows that.
5 tasks
Contributor
|
@fred-wang does this look fine to you? |
Contributor
|
@rsheeter It seems I completely overlooked this message, but yes it looks good to me |
Author
|
@rsheeter Any chance we could get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packagers and distributors which use the CMake-based build system may want to install the
woff2_{decompress,compress,info}tools as well when building shared libraries. Usingcmake -DINSTALL_TOOLS=ONallows that.I found myself wanting to this do the when writing an Arch Linux package for
woff2-1.0.1. Previously there was a woff2-git package which only installed the tools, and therefore the package I made is expected to provide the tools as well because people who already hadwoff2-gitinstalled and move over to thewoff2package will expect them to be there.