Skip to content

Ensure that RenderFormattedMessageXML always returns valid UTF-8. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 2, 2025
Merged

Ensure that RenderFormattedMessageXML always returns valid UTF-8. #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion winlog/winlog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,14 @@ func RenderFragment(fragment windows.Handle, flag uint32) (string, error) {
return "", fmt.Errorf("wevtapi.EvtRender failed: %v", err)
}

return syscall.UTF16ToString(buf), nil
// syscall.UTF16ToString handles invalid UTF-16 containing isolated surrogates
// by emitting invalid UTF-8, in the form of a WTF-8 encoded string (see
// https://github.com/golang/go/issues/59971). This allows round-tripping back
// to invalid UTF-16, but means that the emitted XML cannot be parsed by
// anything that expects valid UTF-8. This includes Go's encoding/xml parser.
// Use utf16ToString instead, which substitutes isolated surrogate code points
// with the unicode replacement character, U+FFFD.
return utf16ToString(buf, len(buf)), nil
}

// This is like `syscall.UTF16ToString`, but it supports strings that contain null characters.
Expand Down