Skip bytecode inference of the actual value for assume.
#1629
+73
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do so, I've generalized our existing support for skipping bytecode inference, which I had originally set up for `ExpectFailure` in 3caa0e8 + 24b5a31. This change improves the performance of failed assumptions. It makes the messages of the resulting `AssumptionViolatedException` somewhat worse, but my sense is that no one really looks at those. As discussed in b/478281659, we could go further by also avoiding cleaning stack traces, which probably also no one looks at. RELNOTES=n/a PiperOrigin-RevId: 860252016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip bytecode inference of the actual value for
assume.To do so, I've generalized our existing support for skipping bytecode inference, which I had originally set up for
ExpectFailurein 3caa0e8 + 24b5a31.This change improves the performance of failed assumptions. It makes the messages of the resulting
AssumptionViolatedExceptionsomewhat worse, but my sense is that no one really looks at those. As discussed in b/478281659, we could go further by also avoiding cleaning stack traces, which probably also no one looks at.RELNOTES=n/a