Add support for a sorting order option. #107
Merged
JeffFaer merged 2 commits intogoogle:mainfrom Dec 22, 2025
Merged
Conversation
…nding order (asc by default)
…nding order (asc by default)
JeffFaer
approved these changes
Dec 22, 2025
Collaborator
JeffFaer
left a comment
There was a problem hiding this comment.
Awesome! Thanks for this improvement!
I'm happy to accept this as is, but I believe there might be a little bit more work to do in the future. Regexes support extracting multiple pieces from the current line. Users at some point might want to sort one "column" ascending and another "column" descending, so we might want this option to accept multiple values at some point in the future
Perhaps the behavior would be if there's only one sort order specified, use that for all columns, otherwise require that the number of sort orders matches the number of columns exactly
But we can leave that speculation to the future when someone actually asks for this behavior :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to speciify the sorting order via a new option :
order=(asc|desc)with asc by default (the current behavior)