Skip to content

Conversation

@eliemichel
Copy link
Contributor

In the root CMakeLists.txt, a call to TOUPPER suggests that the value of DAWN_BUILD_MONOLITHIC_LIBRARY might have any case. However, its value is used as is in the call to bundle_libraries, which in turn uses it in a call to add_library, which requires uppercase STATICor SHARED.

This ensures that the argument passed to bundle_libraries is uppercased. Another fix could be to place a call to TOUPPERdirectly within bundle_libraries's definition.

@github-actions
Copy link

👋 Thanks for your contribution! Your PR has been imported to Gerrit.
Please visit https://dawn-review.googlesource.com/c/dawn/+/285403 to see it and CC yourself on the change.
After iterating on feedback, please comment on the Gerrit review to notify reviewers.
All reviews are handled within Gerrit, any comments on the GitHub PR may be missed.
You can continue to upload commits to this PR, and they will be automatically imported
into Gerrit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant