add misc controller metrics #3420
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @mythi. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
moving away from draft to get more feedback. |
any early feedback from the maintainers? |
|
/ok-to-test |
|
Can you undo changes to |
The PR won't build without those changes. I can rebase to resolve conflicts to get the e2e tests going but I believe we can wait with this PR until runc 1.2.0 comes out. |
|
@mythi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
runc 1.2.x is now available in |
eero-t
left a comment
eero-t
left a comment
There was a problem hiding this comment.
Looks fine to me, but I have suggestion about the helper function.
| getValues: func(s *info.ContainerStats) metricValues { | ||
| values := make(metricValues, 0, len(s.Misc)) | ||
| for k, v := range s.Misc { | ||
| values = append(values, metricValue{ | ||
| value: float64(v.Usage), | ||
| labels: []string{k}, | ||
| timestamp: s.Timestamp, | ||
| }) | ||
| } | ||
| return values | ||
| }, | ||
| }, { | ||
| name: "container_misc_events", | ||
| help: "Number of times the usage for the misc scalar resource specified by the label was about to go over the max boundary", | ||
| valueType: prometheus.CounterValue, | ||
| extraLabels: []string{"resource"}, | ||
| getValues: func(s *info.ContainerStats) metricValues { | ||
| values := make(metricValues, 0, len(s.Misc)) | ||
| for k, v := range s.Misc { | ||
| values = append(values, metricValue{ | ||
| value: float64(v.Events), | ||
| labels: []string{k}, | ||
| timestamp: s.Timestamp, | ||
| }) | ||
| } | ||
| return values | ||
| }, |
There was a problem hiding this comment.
This same anon function is duplicated also for s.HugeTlb. Maybe it would make sense to split it into a generic (template) helper function?
|
any maintainers to take a look? |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
bot
added
the
lifecycle/stale
|
pending maintainer review |
|
can you please rebase? let's see if it triggers the ci jobs |
Modeled after Hugetlb support (except that this skips DeprecatedContainerStats) and added to sources after it.
Modeled after Hugetlb support and added to sources after it.
Modeled after Hugetlb support and added to sources after it.
done |
github-actions
bot
removed
the
lifecycle/stale
5 participants
Keeping it draft still since it pulls
github.com/opencontainers/runc@main.