feat: make Microsoft Entra ID tenant configurable#266
Conversation
Add MicrosoftTenant field to provider.Params and AddMicrosoftProvider method to auth.Service, allowing single-tenant Entra ID applications to specify their tenant instead of the hardcoded "common" endpoint. Fixes umputun/remark42#1998
Pull Request Test Coverage Report for Build 21887694868Details
💛 - Coveralls |
Add AUTH_MICROSOFT_TENANT env var to allow configuring the Azure AD tenant for single-tenant Entra ID applications, which cannot use the default /common endpoint. Depends on go-pkgz/auth#266 Closes #1998
Add AUTH_MICROSOFT_TENANT env var to allow configuring the Azure AD tenant for single-tenant Entra ID applications, which cannot use the default /common endpoint. Depends on go-pkgz/auth#266 Closes #1998
|
clean, minimal change - does what it says. CI green, 100% coverage on changed lines, v1/v2 consistent. two things worth considering:
otherwise LGTM |
umputun
left a comment
There was a problem hiding this comment.
LGTM, thx for adding the validation
Add AUTH_MICROSOFT_TENANT env var to allow configuring the Azure AD tenant for single-tenant Entra ID applications, which cannot use the default /common endpoint. Depends on go-pkgz/auth#266 Closes #1998
Summary
MicrosoftTenantfield toprovider.ParamsandAddMicrosoftProvidermethod toauth.Servicecommonendpoint"common"when no tenant is specified, preserving full backwards compatibilityContributes to umputun/remark42#1998