Add skeletal implementation of NSGestureRecognizer#364
Open
Add skeletal implementation of NSGestureRecognizer#364
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements skeletal implementations of several NSGestureRecognizer subclasses and enhances NSEvent to support magnification gestures. The implementation provides a comprehensive gesture recognition framework with concrete recognizers for common gesture types.
- Implements NSGestureRecognizer base class with state management, target-action patterns, and delegate support
- Adds concrete gesture recognizers for click, pan, press, rotation, and magnification gestures with complete event handling
- Extends NSEvent to support magnification properties for enhanced gesture recognition capabilities
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| NSGestureRecognizer.m | Core gesture recognizer base class implementation with state management and event handling |
| NSClickGestureRecognizer.m | Click gesture recognizer with button mask and multi-click support |
| NSPanGestureRecognizer.m | Pan gesture recognizer with translation/velocity tracking and multi-button support |
| NSPressGestureRecognizer.m | Press-and-hold gesture recognizer with timer-based duration validation |
| NSRotationGestureRecognizer.m | Rotation gesture recognizer supporting both mouse and scroll wheel input |
| NSMagnificationGestureRecognizer.m | Magnification gesture recognizer for zoom operations |
| NSEvent.m | Enhanced mouse event creation and serialization to support magnification data |
| Headers/AppKit/*.h | Updated header files with comprehensive documentation and API definitions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…gui into NSGestureRecognizer_branch
Member
Author
|
I think this PR is ready as well, @fredkiefer / @rfm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Gesture recognition logic