Fix ineffective break statement in context_test.go#241
Open
mfielding wants to merge 1 commit intogliderlabs:masterfrom
Open
Fix ineffective break statement in context_test.go#241mfielding wants to merge 1 commit intogliderlabs:masterfrom
mfielding wants to merge 1 commit intogliderlabs:masterfrom
Conversation
From https://staticcheck.dev/docs/checks#SA4011: SA4011 - Break statement with no effect. Did you mean to break out of an outer loop? In Go, the break statement only exits the innermost loop it's currently in. If you're seeing the "ineffective break statement" warning, it's likely because you have a break statement inside a nested loop, but you intended to exit the outer loop. Updating with a `return` to exit the goroutine entirely. The unit test itself isn't affected; it passes before and after this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://staticcheck.dev/docs/checks#SA4011:
SA4011 - Break statement with no effect. Did you mean to break out of an outer loop?
In Go, the break statement only exits the innermost loop it's currently in. If you're seeing the "ineffective break statement" warning, it's likely because you have a break statement inside a nested loop, but you intended to exit the outer loop.
Updating with a
returnto exit the goroutine entirely. The unit test itself isn't affected; it passes before and after this change.