Consider result of ServerConfigCallback when setting NoClientAuth#163
Open
mohammed90 wants to merge 1 commit intogliderlabs:masterfrom
Open
Consider result of ServerConfigCallback when setting NoClientAuth#163mohammed90 wants to merge 1 commit intogliderlabs:masterfrom
ServerConfigCallback when setting NoClientAuth#163mohammed90 wants to merge 1 commit intogliderlabs:masterfrom
Conversation
only disable client auth when it's explicitly disabled or the auth callkbacks on both `*Server` and `ServerConfig` are nil
Collaborator
|
This seems like a good solution. I'll try to take a look and get this merged in the next few days. |
Collaborator
|
@belak PING |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this when I was controlling the authentication methods on per connection basis. Effectively
NoClientAuthends up beingtruefor all connections, regardless of the resultServerConfigCallback, because the authentication callbacks on the server are not configured for the lack of global authentication approach. This commit only disables client authentication when it's explicitly disabled or the authentication callkbacks on both*ServerandServerConfigarenil.