DirectTCPIPHandler func use payload origin addr and port#140
Open
eudore wants to merge 1 commit intogliderlabs:masterfrom
eudore:directTCPIP-use-origin
Open
DirectTCPIPHandler func use payload origin addr and port#140eudore wants to merge 1 commit intogliderlabs:masterfrom eudore:directTCPIP-use-origin
eudore wants to merge 1 commit intogliderlabs:masterfrom
eudore:directTCPIP-use-origin
Conversation
belak
reviewed
Sep 29, 2020
| IP: net.ParseIP(d.DestAddr), | ||
| Port: int(d.DestPort), | ||
| } | ||
| dconn, err := net.DialTCP("tcp", laddr, raddr) |
Collaborator
There was a problem hiding this comment.
This seems like it would be a worthwhile change (though I'm not 100% sure I understand it), but I'd like for it to be done without dropping ctx from the dial call.
I believe this can be done by setting dialer. LocalAddr to the laddr and using the previous method of creating the raddr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DirectTCPIPHandlerfunction establishes a new connection using thenet.TCPAddrfunction so that the address and port of Origin can be set.