-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(prisma): Add prisma v7 support #16133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| The Prisma Integrations creates a spans for each query and reports to Sentry with relevant details inside the`description` if available. | ||
|
|
||
| This integration is enabled by default and supports Prisma versions 5 & 6. In Prisma v5, you need to follow the instructions below to enable tracing. | ||
| This integration is enabled by default and supports Prisma versions 5, 6 & 7. In Prisma v5, you need to follow the instructions below to enable tracing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The documentation incorrectly states that Prisma v5 is supported, but the Sentry SDK v9 migration guide confirms that support for Prisma v5 was dropped.
Severity: MEDIUM
Suggested Fix
Remove all references to Prisma v5 support from the prisma.mdx file. This includes updating the supported versions list to 6.x, 7.x and removing the "Prisma Version 5" section entirely to align with the breaking changes introduced in Sentry SDK v9.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/platforms/javascript/common/configuration/integrations/prisma.mdx#L39
Potential issue: The changes to `prisma.mdx` introduce a contradiction with the official
v8-to-v9 migration guide. The updated documentation claims support for Prisma v5 and
provides configuration details for it. However, the migration guide explicitly states
that "Prisma version `5.x` and below are no longer supported" in SDK v9. Since
`prisma.mdx` represents the documentation for the latest SDK version, users following
these instructions for an SDK v9+ project will encounter runtime issues when their
configuration fails due to using an unsupported Prisma version.
Did we get this right? 👍 / 👎 to inform future reviews.
nicohrubec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
DESCRIBE YOUR PR
Adds docs for getsentry/sentry-javascript#18908
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES