FIX #281 Inconsistency in case types( camelCase and snake_case) in characters api #282
Open
Thiru-kumaran-R wants to merge 2 commits intogenshindev:mistressfrom
Open
FIX #281 Inconsistency in case types( camelCase and snake_case) in characters api #282Thiru-kumaran-R wants to merge 2 commits intogenshindev:mistressfrom
Thiru-kumaran-R wants to merge 2 commits intogenshindev:mistressfrom
Conversation
… including 'add_type_to_character.js' and 'add_weapon_type.js'
Thiru-kumaran-R
changed the title
Thiru-kumaran-R
changed the title
Collaborator
|
I don't think it's a good idea to change attributes that someone's app may already depend on. If anything, I'd delete those attributes completely (still a bad idea) because they are duplicates of "vision" and "weapon" |
Contributor
|
They aren't duplicates. Notice that visionKey and weaponType are always (mostly so pt translations which can be fixed) in english while vision and weapon are in a specific language. So they are entirely useless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX #281 ,resolved inconsistency issue in casing in all json file in characters including 'add_type_to_character.js' and 'add_weapon_type.js'