Skip to content

Cumulative changes from feedback#166

Merged
ganelson merged 6 commits intoganelson:masterfrom
curiousdannii:cumulative
Aug 5, 2024
Merged

Cumulative changes from feedback#166
ganelson merged 6 commits intoganelson:masterfrom
curiousdannii:cumulative

Conversation

@curiousdannii
Copy link
Contributor

@curiousdannii curiousdannii commented Aug 5, 2024

  • Glk features

    • Changed glk feature support to a definition (I have not updated the WWI docs yet, because I wasn't sure how definitions are typically documented)
    • Added "feature" to the end of each
    • Added the various specific-kind-of-window features as features rather than phrases
  • Windows

    • Renamed the "type" property to "window type"
    • Renamed the "reference number" to "glk window handle"
    • Added "window type" to end of each enum variant
    • Added window subkinds
    • Made the window functions safe or RTP raising
    • Fully track the opening/closing of the quote window
    • Exposed VM_StatusLineHeight
    • Added "say current line input of window" phrase (from Hyperlink framework #162)
  • Events

    • Stop exposing Glk_Event_Struct_type - it now should be read just as the rulebook basis
    • Changed how the text input status is reset, to ensure it won't be inaccurate if someone adds their own "first glk event handling rule"
    • Made "set the glk event type" stop the rulebook, and then rerun the glk event handling rules again
  • Misc

    • Made ShowRTP safe while input is pending, by calling SuspendTextInput/ResumeTextInput
    • Specified the before starting the virtual machine rules as first rules (and therefore had to reorder them too)
  • To do:

    • Remove statuswin_cursize?

@ganelson ganelson merged commit afc7e51 into ganelson:master Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants