Open
Conversation
the blinky project. Things to add or fix: use the command-line info to set the VCD filename, add lint support, work out how to remove the verilator lint_off WIDTH comments in blinky.v.
Added files and blinky.core to support the ULX3S FPGA development board.
olofk
reviewed
Dec 17, 2018
| verilator_tb: | ||
| files: | ||
| - bench/blinky_tb.cpp : {file_type : cppSource} | ||
| - bench/testb.h : {file_type : user} |
Contributor
There was a problem hiding this comment.
This should be specified as {file_type : cppSource, is_include_file : true} so that the backend knows to include the directory of the file in the include path
| tools: | ||
| verilator: | ||
| verilator_options : [--trace] | ||
| parameters : [clk_freq_hz=10000] |
Contributor
There was a problem hiding this comment.
I just checked that VCD generation works just fine if you create a new parameter (by adding an entry under the parameters section near the end of the core file) that looks like this
vcd:
datatype : bool
paramtype : plusarg
add then add the newly created vcd parameter to the list of parameters for the target (i.e. change the line above to parameters : [clk_freq_hz=10000, vcd]
|
|
||
| always @(posedge clk) begin | ||
| count <= count + 1; | ||
| /* verilator lint_off WIDTH */ |
Contributor
There was a problem hiding this comment.
I will add a proper fix for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is an initial version which provides Verilator support. I'm not recommending that you adopt it as-is, but perhaps you can look at it and see how it can be modified to be acceptable. Thanks!
Things to add or fix: use the command-line info to set the VCD filename, add lint support, work out how to remove the verilator lint_off WIDTH comments in blinky.v.