Skip to content

Remove funtracks deprecation warnings and TracksController#330

Open
TeunHuijben wants to merge 10 commits intomainfrom
258-deprecation-warnings
Open

Remove funtracks deprecation warnings and TracksController#330
TeunHuijben wants to merge 10 commits intomainfrom
258-deprecation-warnings

Conversation

@TeunHuijben
Copy link
Collaborator

Ongoing work to make motile_tracker compatible with funtracks v2(-dev).

This PR focuses on:

  • removing any deprecation warnings
  • removing TracksController

@TeunHuijben TeunHuijben linked an issue Feb 2, 2026 that may be closed by this pull request
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.13%. Comparing base (562e35e) to head (e5f83f9).

Files with missing lines Patch % Lines
src/motile_tracker/motile/backend/solve.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   86.35%   87.13%   +0.78%     
==========================================
  Files          51       52       +1     
  Lines        4244     4245       +1     
==========================================
+ Hits         3665     3699      +34     
+ Misses        579      546      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TeunHuijben
Copy link
Collaborator Author

TeunHuijben commented Feb 4, 2026

All deprecation warnings are gone, and tracks_controller is completely removed from motile_tracker.

Excusez-moi, for adding tests in this PR, instead of making a new one.

What remains to be done:

  • TrackPoints._update_data used UserAddNod, but this function needs the new_node_id. Previously, we used Trackscontroller._get_new_node_ids, but we lost the TracksController. Solutions: 1) host _get_new_node_ids somewhere in Tracks (can be accelerated using tracksdata, later), or 2) stick to current while look (bad)
  • After merging two PRs in funtracks, we can replace the funtracks pin in pyproject

@TeunHuijben
Copy link
Collaborator Author

Ready for review! But we should only merge after Funtracks PRs 155 and 156 are merged (so I can replace the git commit pin in pyproject by an actual version)

@TeunHuijben TeunHuijben marked this pull request as ready for review February 4, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to v2 API

3 participants