Skip to content

update: publish package to github #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Isha-Sharma wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update: publish package to github #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b23ef
update(major): publish package to github
Isha-Sharma Nov 27, 2025
a5097ef
CI: bumps oidc-client version to 3.0.1-github-package.0
Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
- name: Install dependencies
run: npm ci
- name: Run lint
Expand All @@ -35,12 +35,12 @@ jobs:
app_id: ${{ vars.FUNDABOT_APP_ID }}
private_key: ${{ secrets.FUNDABOT_PRIVATE_KEY }}

- uses: actions/checkout@v3
- uses: actions/checkout@v5
if: ${{ github.ref_name == 'main' }}
with:
token: ${{ steps.generate_token.outputs.token }}

- uses: actions/checkout@v3
- uses: actions/checkout@v5
if: ${{ github.ref_name != 'main' }}

- name: Version bump
Expand Down Expand Up @@ -83,11 +83,11 @@ jobs:
environment: ${{ github.ref_name == 'main' && 'prod' || '' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v5
- run: git pull origin ${{ github.ref }}
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
registry-url: https://registry.npmjs.org
- name: Install dependencies
run: npm ci
Expand All @@ -96,20 +96,20 @@ jobs:
env:
NODE_AUTH_TOKEN: ${{secrets.NPMJS_TOKEN}}

publish-gitlab:
publish-github:
needs: release
environment: ${{ github.ref_name == 'main' && 'prod' || '' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v5
- run: git pull origin ${{ github.ref }}
- name: Setup .npmrc file for publish
env:
GITLAB_TOKEN: ${{secrets.GITLAB_TOKEN}}
run: |
echo @fundwave:registry=https://gitlab.com/api/v4/projects/24877554/packages/npm/ >> ~/.npmrc
echo //gitlab.com/api/v4/projects/24877554/packages/npm/:_authToken=$GITLAB_TOKEN >> ~/.npmrc
- uses: actions/setup-node@v4
with:
node-version: 20
registry-url: https://npm.pkg.github.com
- name: Install dependencies
run: npm ci
- name: Publish package
run: npm publish --tag $BRANCH_TAG
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable BRANCH_TAG is referenced but never defined in this job. This will cause the publish command to fail or publish without the intended tag. Define BRANCH_TAG in the environment or as a step output before using it.

Copilot uses AI. Check for mistakes.
env:
NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@fundwave/oidc-client",
"version": "3.0.0",
"version": "3.0.1-github-package.0",
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The version string '3.0.1-github-package.0' uses a non-standard prerelease identifier. Consider using a more conventional prerelease format like '3.0.1-alpha.0', '3.0.1-beta.0', or '3.0.1-rc.0' to align with semantic versioning best practices.

Suggested change
"version": "3.0.1-github-package.0",
"version": "3.0.1-alpha.0",

Copilot uses AI. Check for mistakes.
"description": "Client for managing tokens for API Calls",
"license": "MIT",
"author": "The Fundwave Authors",
Expand Down Expand Up @@ -34,10 +34,10 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/getfundwave/oidc-client.git"
"url": "git+https://github.com/fundwave/oidc-client.git"
},
"bugs": {
"url": "https://github.com/getfundwave/oidc-client/issues"
"url": "https://github.com/fundwave/oidc-client/issues"
},
"homepage": "https://github.com/getfundwave/oidc-client#readme"
"homepage": "https://github.com/fundwave/oidc-client#readme"
}