Skip to content

cleanup & fixes & general improvements #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gauron99 merged 2 commits into from
Jan 23, 2026
Merged

cleanup & fixes & general improvements #1

gauron99 merged 2 commits into from
Jan 23, 2026

Conversation

@gauron99
Copy link
Collaborator

@gauron99 gauron99 commented Jan 20, 2026 •
edited
Loading

  • code cleanup & improvement
  • more workflow tests
  • custom optional binary URL
  • pin deps to specific versions

@gauron99 gauron99 force-pushed the push-vrrzxxrmqkrn branch 4 times, most recently from 96c687a to 19abfa8 Compare January 20, 2026 19:59
twoGiants
twoGiants suggested changes Jan 21, 2026
View reviewed changes
Copy link

@twoGiants twoGiants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! 😸 👍

Awesome to have tests now and the code reads much better!

Now that this action is taken care off, I can chime in on more improvements 😁

Core things I found:

  • curl will download 404 pages with wrong versions => can be fixed
  • cmdConstructAndRun can be named better a do a bit more
  • optional: binary url source could be a variable with a github release page default

@gauron99 gauron99 changed the title cleanup & fixes for function action cleanup & fixes & general improvements for function action Jan 23, 2026
@gauron99 gauron99 changed the title cleanup & fixes & general improvements for function action cleanup & fixes & general improvements Jan 23, 2026
twoGiants
twoGiants approved these changes Jan 23, 2026
View reviewed changes
Copy link

@twoGiants twoGiants left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Approved! 😸 👍

You removed the node_modules too, that is very good. They are installed when the action is added to a workflow, right?

@gauron99 gauron99 merged commit 675fe07 into main Jan 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@twoGiants twoGiants twoGiants approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gauron99 @twoGiants