FS-11275 180/183 after 200 causes call to stall and never recovers

[sunlin7]

Hi,

This PR will fix the issue https://freeswitch.org/jira/browse/FS-11275, the root cause is once the 180/183 message behind the 200 message (network jetter), sofia will to waiting the ACK for 180/183, until timeout.
The solution is, ignore the 180/183 if current state already is completed.

Please help review and merge the change.

Thanks

[freeswitch-ci-system]

Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/freeswitch/sofia-sip/140/artifacts.html

[sunlin7]

@crienzo please help review this change, the checks failed on unrelated part. Thanks

[mjerris]

i thought this patch f6ac484 addressed this issue. is yours still needed?

[sunlin7]

Hi @mjerris,
Yes, current change is still needed.
The f6ac484 didn't resolve the issue I met,
The message arrive the funcation outgoing_find first,

sofia-sip/libsofia-sip-ua/nta/nta.c

Line 9368 in 756ab9b

nta_outgoing_t *outgoing_find(nta_agent_t const *sa,

The status original->orq_status be changed;
Then it proceed by the nua_session_client_response in f6ac484 to response to remote.

sofia-sip/libsofia-sip-ua/nua/nua_session.c

Line 924 in 756ab9b

static int nua_session_client_response(nua_client_request_t *cr,

I had tested this change, confirm it resolved the ticket FS-11275; without this change, there will have an error when the 183 after the 200 message.

[sunlin7]

@mjerris @dragos-oancea ,
Please hlep to review and merge this PR. Thanks.

[mjerris]

can you add a unit test that works after your pr but does not work before it with current master please?

[sunlin7]

OK, I'll try to add unit test for this PR. Thanks