Skip to content

Fix/site jobs#272

Merged
revant merged 7 commits intofrappe:mainfrom
Improwised:fix/site-jobs
Feb 4, 2026
Merged

Fix/site jobs#272
revant merged 7 commits intofrappe:mainfrom
Improwised:fix/site-jobs

Conversation

@disha-itpl
Copy link
Contributor

@disha-itpl disha-itpl commented Jan 27, 2026

Description: Fix the site-jobs to run properly and do site operations successfully.

  • Fix the create-site job to run the command as singleline string
  • Fix the drop-site-job to run the command as the singleline string and removed --db-host argument form the command as it is not part of the command
  • Fix backup job to run the command as singleline string

Fixes: #270

@disha-itpl disha-itpl marked this pull request as draft January 28, 2026 08:53
@disha-itpl disha-itpl marked this pull request as ready for review January 28, 2026 09:44
@work-with-devia
Copy link

Very necessary! <3

@revant revant merged commit d2ef4bc into frappe:main Feb 4, 2026
1 check passed
@disha-itpl
Copy link
Contributor Author

Hi @revant ,

After this PR was merged, I checked the chart on Artifact Hub. While the chart version is updated, the template changes do not appear to be reflected there.

To double-check, I tested the functionality by deploying the chart and running one of the jobs that was modified as part of this change. During testing (specifically with the create-site and drop-site jobs), the command still appears to be rendered and executed as multiple lines, rather than a single-line command as intended.

I verified this by checking the job logs, where the command seems to break across lines, causing the job to not behave as expected.

Could you please take a look at this when you get a chance? I just wanted to flag this in case something was missed during the packaging or publishing step.

Thanks a lot for your time and for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiline args string breaks

3 participants