Skip to content

Use label to identify pods belonging to the Frappe deployment#268

Merged
revant merged 5 commits intofrappe:mainfrom
AislerHQ:main
Feb 4, 2026
Merged

Use label to identify pods belonging to the Frappe deployment#268
revant merged 5 commits intofrappe:mainfrom
AislerHQ:main

Conversation

@PatrickFranken
Copy link
Contributor

As the Kubernetes-based deployment of ERPNext requires RWX volumes, it's rather difficult to deploy on a cluster where the infrastructure provider does not offer such volumes. NFS is a workaround but also difficult to deploy right in a production environment. Due to this, IMHO it's a valid option to place all ERPNext pods on one single node which allows so share a usual RWO volume.
This scheduling can be achived using

nginx: 
  nodeSelector:
    system/ais-deployment: default
  affinity:
    podAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        - labelSelector:
            matchLabels:
              app.kubernetes.io/app: frappe
          topologyKey: kubernetes.io/hostname

(The same has to be applied for all deployments, nginx is used as an example here)

This MR adds a common label to all pods, as this is required for this kind of affinity.

@PatrickFranken
Copy link
Contributor Author

@revant any chance to review and merge this? Not sure about the failed check, looks like it's not related to these changes. Let me know if you need any more information.

@revant
Copy link
Collaborator

revant commented Feb 3, 2026

https://github.com/frappe/helm/blob/main/CONTRIBUTING.md#run-pre-commit

Run this and commit the changes. That'll fix lint failures.

@PatrickFranken
Copy link
Contributor Author

@revant sorry, should have read that before. Branch is now up-to-date.

@revant revant merged commit 53f597d into frappe:main Feb 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants