FIO-9524: Fix bad request when fetching nested form#5966
Closed
mikekotikov wants to merge 3 commits intomasterfrom
Closed
FIO-9524: Fix bad request when fetching nested form#5966mikekotikov wants to merge 3 commits intomasterfrom
mikekotikov wants to merge 3 commits intomasterfrom
Conversation
7 tasks
brendanbond
requested changes
Jan 7, 2025
Contributor
brendanbond
left a comment
There was a problem hiding this comment.
So if I understand this correctly, esignature is bundling a version of Formio with itself. Isn't this the fundamental problem? Why does esignature need to bundle Formio, it should depend on it as a peer dependency (or as an external in webpack)
Contributor
Author
@brendanbond you're right 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9524
Description
What changed?
When esignature module is used, the nested form gets initialized with a Formio from it's build. And it doesn't have a set project url that matches currently open project. So the final link to the nested form is malformed and 400 Bad Request happens.
I've tried adjusting the imports of Formio to point to same Formio instance, but didn't succeed with that approach.
So as another solution I've managed to pass the project URL in the options object and use it if it's present.
Why have you chosen this solution?
Use this section to justify your choices
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
ngFormio#741
How has this PR been tested?
Automated test is added
Checklist: