feat: add folder support for organizing secrets (Phase 2c-X2)#167
Merged
forest6511 merged 2 commits intomainfrom Jan 22, 2026
Merged
feat: add folder support for organizing secrets (Phase 2c-X2)#167forest6511 merged 2 commits intomainfrom
forest6511 merged 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 67.02% 66.37% -0.65%
==========================================
Files 18 19 +1
Lines 2920 3423 +503
==========================================
+ Hits 1957 2272 +315
- Misses 690 802 +112
- Partials 273 349 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Implements folder feature per ADR-007 specification: **Vault Package:** - Add Folder struct and CRUD operations (Create, Get, Update, Delete, List) - Add MoveSecretToFolder and ListSecretsInFolder operations - Add path resolution (e.g., "Work/APIs") with max depth 10 - Add unique name constraint (case-insensitive per parent) - Database schema v5 with folders table and folder_id in secrets **CLI Commands:** - `folder create <name>` - Create folder with optional parent/icon/color - `folder list` - List folders with tree view - `folder delete <id>` - Delete folder (--force for non-empty) - `folder rename <id> <name>` - Rename folder - `folder move <id> --parent <parent>` - Move folder - `folder info <id>` - Show folder details - `set --folder <path>` / `--folder-id <id>` - Set secret in folder - `list --folder <path>` / `--folder-id <id>` - Filter by folder **MCP Tools:** - `folder_list` - List folders with metadata - `folder_create` - Create new folder - `folder_move_secret` - Move secret to folder - `secret_list` now includes folder_id filter and folder_path **Tests:** - 9 test functions with 29 subtests - Coverage: folder CRUD, validation, path resolution, depth limit
- Use defer for rows.Close() where appropriate - Keep manual Close() in loop where defer causes resource leak - Disable ifElseChain and unnamedResult for cleaner pointer-nil patterns - Exclude sqlclosecheck for folder.go (manual close required in loops) - Exclude unparam for test files
forest6511
force-pushed
the
feature/folder-support
branch
from
6c7f65a to
e00983a
Compare
2 tasks
forest6511
added a commit
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements folder feature per ADR-007 specification for organizing secrets into hierarchical folders.
Features Added
Vault Package:
CLI Commands:
folder create <name>- Create folder with optional parent/icon/colorfolder list- List folders with tree viewfolder delete <id>- Delete folder (--force for non-empty)folder rename <id> <name>- Rename folderfolder move <id> --parent <parent>- Move folderfolder info <id>- Show folder detailsset --folder <path>- Set secret in folderlist --folder <path>- Filter by folderMCP Tools:
folder_list- List folders with metadatafolder_create- Create new folderfolder_move_secret- Move secret to foldersecret_listnow includes folder_id filter and folder_pathTest plan
Related