Skip to content

Conversation

@samhita-alla
Copy link
Contributor

@samhita-alla samhita-alla commented Mar 11, 2025

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

this PR adds the mosaic data streamer to flytedirectory. i have some examples, but haven’t included them in this PR. merge this only if native integration is necessary. otherwise, supporting mosaic streaming through examples and tutorials should be sufficient.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at eduardo@union.ai.

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at eduardo@union.ai.

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 32.52033% with 83 lines in your changes missing coverage. Please review.

Project coverage is 75.88%. Comparing base (7915afa) to head (9438bbc).
Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/types/directory/types.py 31.96% 79 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
- Coverage   78.71%   75.88%   -2.83%     
==========================================
  Files         293      277      -16     
  Lines       25790    25004     -786     
  Branches     2897     2947      +50     
==========================================
- Hits        20300    18974    -1326     
- Misses       4681     5213     +532     
- Partials      809      817       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at eduardo@union.ai.

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at eduardo@union.ai.

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
@flyte-bot
Copy link
Contributor

flyte-bot commented Apr 17, 2025

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Automatic Review Skipped - Draft PR

    Bito didn't auto-review because this pull request is in draft status.
    To trigger review, mark the PR as ready or type /review in the comment and save.
    You can change draft PR review settings here, or contact the agent instance creator at eduardo@union.ai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants