Add missing message classes for S2Parser#147
Merged
lfse-slafleur merged 2 commits intoflexiblepower:mainfrom Nov 26, 2025
Merged
Add missing message classes for S2Parser#147lfse-slafleur merged 2 commits intoflexiblepower:mainfrom
lfse-slafleur merged 2 commits intoflexiblepower:mainfrom
Conversation
Member
|
@philipptrenz Morning! It seems no notifications got send out as the CODEOWNERS wasn't reviewed and merged yet. Just saw this PR so apologies for the delay. Thanks for the additions! |
lfse-slafleur
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous releases the mapping for OBMC, but also DDBC as well as parts of the PPBC messages could not be parsed due to missing mappings in
TYPE_TO_MESSAGE_CLASS. This PR solves that by generating those using thedevelopment_utilities/generate_s2_message_type_to_class.pyscript and adding them tos2_parser.py