The abstract client class

[VladIftime]

This should represent an 'interface' for devs to use as a client for the WebSocket connection.

• Add a test using an FRBC RM

[MauriceHendrix]

Just a few comments to discuss, will look more closely later if I get some time

[MauriceHendrix]

I guess we need a discussion on what's the best default and how to communicate this

[MauriceHendrix]

hhm I wonder if we want to couple the JWK and encryption methods inside the abstract class or not.

[Flix6x]

from typing import TYPE_CHECKING
if TYPE_CHECKING:
    from jwskate import Jwk

[MauriceHendrix]

A few general comments:

• your ci fails because it doesn't seem to install websockets, correctly, I think you need to add it to dev-requirements.txt

• can we use the logging module instead of the many print statements?

• I'm a bit concerned about backwards compatibility, for example with moving s2_connection terms of moving I think it should be possible with some trickery with various imports in init.py files to make it importable from it's original location, as long as the old signatures will work.

• the abstract client seems to contain a few specifics around jwk's and tokens, that we may prefer to leave up to the implementation / default client?

[MauriceHendrix]

I had a quick look.
In terms of moving the imports you could probably solve it by adding something like the following to __init__.py (in the `src folder):

import sys
from s2python.communication.s2_connection import S2Connection
sys.modules['s2python.s2_connection'] = sys.modules.get('s2python.communication.s2_connection', None)

[MauriceHendrix]

I had a quick look. In terms of moving the imports you could probably solve it by adding something like the following to __init__.py (in the `src folder):

import sys
from s2python.communication.s2_connection import S2Connection
sys.modules['s2python.s2_connection'] = sys.modules.get('s2python.communication.s2_connection', None)

actually sorry @VladIftime looks like it needs to be one level up, I changed that myself

[MauriceHendrix]

I moved the backward compatibility fix as I suggested the wrong place, sorry. I Think you don't need the pass statements, but do need to add jwskate to dev-requirements.txt @VladIftime

[MauriceHendrix]

@VladIftime see #119 for fixes to tests and linting errors

[MauriceHendrix]

Suggested change

	this would use a WebSocket library like websocket-client or websockets.
	this uses a WebSocket library like websocket-client or websockets.

[MauriceHendrix]

Suggested change

	logger.info("Would close WebSocket connection")
	logger.info("WebSocket connection closed")

[MauriceHendrix]

Suggested change

	# Create challenge (normally would be a JWE)
	# Create challenge (normally a JWE)

[VladIftime]

move the examples into the source.

[jorritn]

The example would also serve to run an integration test.