Show deprecation warning #463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds SDK deprecation warning functionality to the FishjamClient. When a peer authenticates with the server, the server can now return deprecation status information, which the client will log appropriately based on the severity level.
Changes:
- Added deprecation warning handling in FishjamClient that logs warnings/errors when the SDK version is deprecated or unsupported
- Updated protobuf definitions to include SDK deprecation status and message in the authentication response
- Updated protoc version from v6.33.0 to v6.33.4 across all generated protobuf files
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ts-client/src/FishjamClient.ts | Added import for deprecation status enum and logic to check and log deprecation warnings during authentication |
| packages/protobufs/fishjam/peer_notifications.ts | Added PeerMessage_SdkDeprecation interface with status enum and message field, integrated into PeerMessage_Authenticated |
| packages/protobufs/fishjam/server_notifications.ts | Updated protoc version comment from v6.33.0 to v6.33.4 |
| packages/protobufs/fishjam/notifications/shared.ts | Updated protoc version comment from v6.33.0 to v6.33.4 |
| packages/protobufs/fishjam/media_events/shared.ts | Updated protoc version comment from v6.33.0 to v6.33.4 |
| packages/protobufs/fishjam/media_events/server/server.ts | Updated protoc version comment from v6.33.0 to v6.33.4 |
| packages/protobufs/fishjam/media_events/peer/peer.ts | Updated protoc version comment from v6.33.0 to v6.33.4 |
| packages/protobufs/fishjam/agent_notifications.ts | Updated protoc version comment from v6.33.0 to v6.33.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)