Skip to content

Conversation

@MiloszFilimowski
Copy link
Collaborator

@MiloszFilimowski MiloszFilimowski commented Jan 28, 2026

Description

  • Added ability to set SDK Version in ts-client (with a guard on two options)
  • Added ability to override FishjamClient instance in FishjamProvider
  • Hardcoded mobile in mobile SDK

Motivation and Context

  • Mobile app was using web sdk version.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear
Copy link

linear bot commented Jan 28, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the mobile app was incorrectly reporting itself as using the web SDK version. It introduces a ClientType type with two options ('web' | 'mobile') and adds the ability to set the client type when creating a FishjamClient. The mobile SDK now correctly hardcodes the clientType to 'mobile', ensuring accurate SDK version reporting.

Changes:

  • Added ClientType type and clientType optional parameter to SDK configuration
  • Updated FishjamClient to use configurable clientType when constructing the sdkVersion string
  • Hardcoded clientType to 'mobile' in the mobile-client FishjamProvider wrapper

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/ts-client/src/types.ts Added ClientType type definition and clientType field to CreateConfig
packages/ts-client/src/index.ts Exported ClientType type for public API consumption
packages/ts-client/src/FishjamClient.ts Added clientType property and updated sdkVersion construction to use configurable client type
packages/react-client/src/FishjamProvider.tsx Added clientType prop to FishjamProviderProps and passed it to FishjamClient
packages/mobile-client/src/useForegroundService.ts Cleaned up trailing whitespace in JSDoc comments
packages/mobile-client/src/index.ts Hardcoded clientType to 'mobile' and improved code formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MiloszFilimowski MiloszFilimowski force-pushed the mfilimowski/fce-2497-sdk-version-ref branch from 4deeaeb to b989423 Compare January 28, 2026 11:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants