flamenco, runtime, vm: fix accounts_resize_delta to use signed arithmetic #8068
+692
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topointon-jump
force-pushed
the
firedancer-auditor-internal-371
branch
from
4334ed5 to
ee89363
Compare
topointon-jump
force-pushed
the
firedancer-auditor-internal-371
branch
from
ee89363 to
e5564b5
Compare
topointon-jump
changed the title
two-heart
approved these changes
Jan 29, 2026
Contributor
|
feels weird that we just cast down ulong to long in some places now |
Contributor
Author
|
The casts are disgusting but unfortunately necessary to support negative resize deltas. Agave has the same casts: let length_delta = (new_length as i64).saturating_sub(old_length as i64);Also added a unit test for this case specifically. |
mjain-jump
approved these changes
Jan 29, 2026
ibhatt-jumptrading
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/firedancer-io/auditor-internal/issues/371