Fix CPU topo in fd_shmem
#8065
Open
Fix CPU topo in fd_shmem
#8065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGuillemet
force-pushed
the
fix-cpu-topo-in-fd-shmem
branch
from
f6bec8d to
fcc45b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd_shmem_adminassumes no CPU were made offline. This may result in wrong numa assignment or errors when trying, eg, to set a tile affinity for cpu 63 on a 64-cpu machine with some of them offline.This is particularly problematic since a warning is generated at startup that suggests to put pack and poh siblings offline.
This PR proposes a fix by using the information reported by
fd_cpu_topo.c.Should fix #4428, at least my comment. Not sure about @ripatel-fd original issue.