runtime: harden feature activation logic #8025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripatel-fd
force-pushed
the
feature-activation
branch
from
3866922 to
4c829f3
Compare
Performance Measurements ⏳
|
- Only consider accounts owned by the feature program for activation (fixes a stray FD_LOG_WARNING for account 9LZdXeKGeBV6hRLdxS1rHbHoEUsKqesCC2ZAPTPKJAbK, which was initialized a year ago, but is still owned by the system program) - Do not crash with FD_LOG_CRIT if the feature account is too small to activate, log a warning instead - Simplify serialization logic Reported-by: man0s <man0s@temporal.xyz>
ripatel-fd
force-pushed
the
feature-activation
branch
from
4c829f3 to
6b08d77
Compare
Performance Measurements ⏳
|
| if( FD_UNLIKELY( !fd_feature_decode( &feature, fd_accdb_ref_data_const( ro ), fd_accdb_ref_data_sz( ro ) ) ) ) { | ||
| FD_LOG_WARNING(( "cannot activate feature %s, corrupt account data", addr_b58 )); | ||
| FD_LOG_HEXDUMP_NOTICE(( "corrupt feature account", fd_accdb_ref_data_const( ro ), fd_accdb_ref_data_sz( ro ) )); | ||
| fd_accdb_close_ro( accdb, ro ); |
Contributor
There was a problem hiding this comment.
if feature account is malformed should we crash here
Contributor
Author
There was a problem hiding this comment.
IMO no because Agave doesn't crash either here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
activation (fixes a stray FD_LOG_WARNING for account
9LZdXeKGeBV6hRLdxS1rHbHoEUsKqesCC2ZAPTPKJAbK, which was
initialized a year ago, but is still owned by the system
program)
small to activate, log a warning instead