Skip to content

Conversation

@pavelgj
Copy link
Collaborator

@pavelgj pavelgj commented Jan 27, 2026

Checklist (if applicable):

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @pavelgj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the Genkit Go library's reflection capabilities by introducing a new Reflection API V2. This version transitions from a traditional server-side reflection model to a client-side WebSocket-based approach, facilitating real-time, bidirectional communication with a Genkit runtime manager. The change allows for more robust and interactive introspection and control over Genkit actions and values, improving integration with development tools and environments.

Highlights

  • Reflection API V2 Implementation: Introduces a new Reflection API V2 for Go, leveraging WebSockets and JSON-RPC 2.0 for enhanced communication with a runtime manager.
  • Conditional Startup: The Init function in genkit.go now dynamically selects between Reflection API V1 (server-based) and V2 (client-based) based on the GENKIT_REFLECTION_V2_SERVER environment variable.
  • WebSocket Client with Retry Logic: A new reflectionClientV2 is implemented to manage WebSocket connections, including automatic reconnection attempts upon failure.
  • JSON-RPC 2.0 Handling: The V2 client processes JSON-RPC 2.0 requests such as listActions, listValues, runAction, and cancelAction, and handles notifications like configure.
  • New Test Coverage: A dedicated test file reflection_v2_test.go has been added to validate the functionality of the new Reflection API V2 client.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Reflection API V2, enabling communication with the runtime manager via WebSocket. It includes a new reflection_v2.go file with the implementation and updates genkit.go to conditionally start either the V1 or V2 reflection server based on the GENKIT_REFLECTION_V2_SERVER environment variable. Additionally, it adds reflection_v2_test.go for testing the new functionality and modifies go.mod to remove the indirect tag from github.com/gorilla/websocket. I have added a review comment to address a potential issue with mutex locking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant