-
Notifications
You must be signed in to change notification settings - Fork 651
feat(cli,js): implemented reflection API v2 in CLI and JS #4295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pj/bidi-actions
Are you sure you want to change the base?
Conversation
it's behind `--experimental-reflection-v2` flag. RFC: #4211
Summary of ChangesHello @pavelgj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements the experimental Reflection API V2, which shifts from HTTP to WebSockets for improved communication between the Genkit CLI and Genkit Runtimes. This architecture simplifies runtime management and introduces streaming capabilities. The changes include a new WebSocket-based runtime manager, updates to the CLI start command, and modifications to the common library to support the new protocol. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Reflection API V2, which leverages WebSockets for bidirectional communication between the Genkit CLI and Runtimes. This is a significant architectural change that reverses the connection direction, allowing the CLI to act as a server and Runtimes as clients. The implementation includes a new BaseRuntimeManager abstract class, with separate concrete implementations for V1 (HTTP-based) and V2 (WebSocket-based) managers, ensuring a clean separation of concerns. The changes also include necessary dependency updates, new CLI options to enable V2, and comprehensive test coverage for the new WebSocket manager and server components. The documentation for the V2 protocol is well-detailed, outlining the message formats and protocol flow. Overall, this is a well-designed and implemented feature that enhances the flexibility and capabilities of the Genkit reflection mechanism.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ate `startManager` test call with new optional parameters.
it's behind
--experimental-reflection-v2flag.RFC: #4211
Checklist (if applicable):