-
Notifications
You must be signed in to change notification settings - Fork 650
docs: Adds genkit-js skill as a starting point for Genkit agent skills.
#4284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @mbleigh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the project's documentation and skill structure by migrating from a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the documentation structure by moving .guides content into a new top-level skills directory, aiming to integrate Genkit with skills.sh and the skills NPM package. It also includes dependency updates for next and sharp packages. Overall, the changes improve the organization of skill-related documentation.
| ### Image Generation | ||
| See `references/nano-banana.md` for information about using Nano Banana models for image generation and editing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference to references/nano-banana.md points to a file that was removed in this pull request. This creates a broken link in the documentation. Please either restore the nano-banana.md file in the references directory or update this reference to point to the correct, existing documentation for image generation.
js/plugins/next/package.json
Outdated
| "genkit": "workspace:*", | ||
| "jest": "^29.7.0", | ||
| "next": "^15.2.4", | ||
| "next": "15.3.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next dependency has been changed from a caret range (^15.2.4) to a pinned version (15.3.6). While pinning ensures stability, it also means that minor and patch updates (which often include bug fixes and performance improvements) will not be automatically applied. Please confirm if this change in dependency management strategy is intentional for this package.
| @@ -1,3 +1,17 @@ | |||
| --- | |||
| name: genkit-js | |||
| description: Use the Genkit AI SDK to build application features and agents with LLMs and other GenAI models for JavaScript/TypeScript applications. ALWAYS use this skill when writing Genkit code. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase "ALWAYS use this skill when writing Genkit code" is quite strong. While it's good to emphasize its importance, consider softening it to a strong recommendation, e.g., "It is highly recommended to use this skill..." or "This skill should be used...". This allows for more flexibility in edge cases where it might not strictly apply.
| export const ai = genkit({ | ||
| plugins: [googleAI()], | ||
| model: googleAI.model('gemini-2.5-flash'), | ||
| model: googleAI.model('gemini-3-flash-preview'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default model in the setup guide has been updated to gemini-3-flash-preview. As this is a preview model, it might be subject to more frequent changes or less stability compared to a generally available (GA) model. Consider recommending a stable GA model (e.g., gemini-2.5-flash or gemini-2.5-pro) as the default for a general setup guide, unless there's a strong reason to default to a preview version.
|
The refactor makes sense. Is |
Co-authored-by: Samuel Bushi <66321939+ssbushi@users.noreply.github.com>
Removes
.guidescontent in favor of a new top-levelskillsdirectory which should allow us to integrate Genkit with https://skills.sh and theskillsNPM package.Checklist (if applicable):