-
Notifications
You must be signed in to change notification settings - Fork 651
feat(js/plugins/compat-oai): generalize STT module naming and add gpt-4o-mini-transcribe #4280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(js/plugins/compat-oai): generalize STT module naming and add gpt-4o-mini-transcribe #4280
Conversation
Summary of ChangesHello @7hokerz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the 'compat-oai' plugin by refactoring its Speech-to-Text (STT) module for improved generality and expanding its capabilities. The core change involves renaming the STT module to a more abstract name, which prevents tight coupling to a particular model and facilitates easier integration of diverse transcription services. Concurrently, it introduces support for the 'gpt-4o-mini-transcribe' model, leveraging the existing STT interface to provide additional transcription options without altering the current API structure. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively generalizes the Speech-to-Text (STT) module by renaming whisper.ts to stt.ts and updating the corresponding imports. This is a good change for maintainability as it decouples the module from a specific model name. The PR also adds support for the gpt-4o-mini-transcribe model, expanding the available STT capabilities. The changes are clear, concise, and align well with the existing structure of the codebase. Overall, this is a solid contribution.
Description here... Help the reviewer by:
whisperto a task-oriented name (stt) to avoid coupling the API surface to a specific model.gpt-4o-mini-transcribeas an additional STT model using the existing STT interface.gpt-4o-transcribe,allowing it to fit into the existing STT interface without introducing new response formats or API surface changes.)
Checklist (if applicable):