Skip to content

Add jpackage_script manpage#155

Merged
mizdebsk merged 1 commit intofedora-java:masterfrom
mizdebsk:pr/155
Feb 19, 2026
Merged

Add jpackage_script manpage#155
mizdebsk merged 1 commit intofedora-java:masterfrom
mizdebsk:pr/155

Conversation

@mizdebsk
Copy link
Member

No description provided.

@mizdebsk mizdebsk requested a review from mkoncek February 18, 2026 21:30
.Cm %install
phase of an RPM build.
The script is written to
.Pa %{buildroot}%{_bindir}/ Ns Ar script_name .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is obvious what is meant. I was wondering if there is another way to distinguish script_name, perhaps by adding italics.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mandoc format uses semantic formatting, annotating meaning and not formatting.
Instead of bold, italics, underline etc. mandoc distinguish between command arguments, environment variables, paths etc.
Eg. Ev PATH Ev means it is env variable, Pa is path, Ar argument etc.
In this particular case we have %{buildroot}%{_bindir}/ with Pa (path) and script_name with Ar (argument), which to me looks correct - script_name is not literal, but argument of the macro.

Copy link
Member

@mkoncek mkoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the manpage. All the important points are present.

@mizdebsk mizdebsk merged commit e541d1f into fedora-java:master Feb 19, 2026
1 check passed
@mizdebsk mizdebsk deleted the pr/155 branch February 19, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants