Skip to content

Updated javascript in MediaAccess#63

Open
alettieri wants to merge 3 commits intofarinspace:masterfrom
alettieri:jsfix
Open

Updated javascript in MediaAccess#63
alettieri wants to merge 3 commits intofarinspace:masterfrom
alettieri:jsfix

Conversation

@alettieri
Copy link

Made an attempt at cleaning up the JS a bit.

Summary

  • Did away with the object literal setting in the class attribute and moved it to the data attribute. Labels can now be parsed using jQuery.data instead of regular expression on the class attribute.
  • Also did away with using setInterval. Modified the workflow to a pub/sub model.
  • Did away with jQuery.live and went with event delegation instead. Document listens for the click event and delegates it down to the MediaAccess button.
  • Added upload support when editor is not present on the screen. Good case for custom post types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants