Skip to content

feat: add famedly control module in docker image#239

Draft
FrenchGithubUser wants to merge 1 commit intomasterfrom
tt/famedly-control-docker
Draft

feat: add famedly control module in docker image#239
FrenchGithubUser wants to merge 1 commit intomasterfrom
tt/famedly-control-docker

Conversation

@FrenchGithubUser
Copy link
Member

SYN-9

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.12%. Comparing base (e9af5a2) to head (e1df2c7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   80.13%   80.12%   -0.01%     
==========================================
  Files         500      500              
  Lines       71220    71220              
  Branches    10703    10703              
==========================================
- Hits        57069    57066       -3     
- Misses      10906    10908       +2     
- Partials     3245     3246       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9af5a2...e1df2c7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the famedly-control-synapse module to the Famedly Synapse Docker image build by introducing a new versioned build argument and extending the mod-pack build matrix used by CI.

Changes:

  • Add FCS_VERSION build arg and install famedly-control-synapse in docker/Dockerfile-famedly.
  • Introduce mod020 including fcs-version and switch the currently-built mod pack list to mod017 + mod020.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
docker/Dockerfile-famedly Adds a new build arg and pip-install of famedly-control-synapse.
.ci/scripts/calculate_builds.py Adds mod020 with fcs-version and updates which mod packs are built.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

synapse-token-authenticator==${STA_VERSION} \
synapse-s3-storage-provider \
synapse-invite-checker==${SIC_VERSION} \
famedly-control-synapse==${FCS_VERSION} \
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

famedly-control-synapse==${FCS_VERSION} is installed unconditionally, but ARG FCS_VERSION has no default. If the build arg isn’t provided (or is empty), pip install will fail due to an invalid requirement. Consider either (a) giving FCS_VERSION a safe default and conditionally installing this package only when set, or (b) ensuring every build always passes a valid FCS_VERSION value.

Suggested change
famedly-control-synapse==${FCS_VERSION} \
${FCS_VERSION:+famedly-control-synapse==${FCS_VERSION}} \

Copilot uses AI. Check for mistakes.
Comment on lines +61 to 71
"mod020": {
"sic-version": "0.4.13",
"sta-version": "0.12.0",
"fcs-version": "0.1.0",
},
}

# Adjust this section to decide what gets built and layered on top
# THIS IS THE SECTION TO EDIT, after you have added the new versions above
current_mod_packs_to_build = ["mod017", "mod019"]
current_mod_packs_to_build = ["mod017", "mod020"]

Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current_mod_packs_to_build includes mod017 and mod020, but only mod020 defines fcs-version. Since Dockerfile-famedly now expects FCS_VERSION for installing famedly-control-synapse, the mod017 job will not have a value to pass through the build matrix. Either add fcs-version to mod017 (and any other packs you still build) or adjust the build selection / Dockerfile logic so packs without FCS can still build successfully.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants