Skip to content

Rework ET Replay Targets #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
briancoutinho wants to merge 1 commit into from
Closed

Rework ET Replay Targets #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion et_replay/comm/commsTraceParser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@

import math

from et_replay import ExecutionTrace
from et_replay.comm import comms_utils
from et_replay.comm.backend.base_backend import supportedP2pOps
from et_replay.comm.comms_utils import commsArgs

from et_replay.execution_trace import ExecutionTrace
Copy link
Contributor

@sanshang-nv sanshang-nv Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no need to add .execution_trace, as ExecutionTrace class has been exported.

param/et_replay/__init__.py

Line 3 in fb81f66

__all__ = ["ExecutionTrace"]

@briancoutinho @shengfukevin


logger = logging.getLogger(__name__)


Expand Down
2 changes: 1 addition & 1 deletion et_replay/comm/comms_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from typing import Any

try:
from param_bench.et_replay.vendor_internals import (
from et_replay.vendor_internal.fb_internal import (
initialize_collectiveArgs_internal,
remove_quantization_handlers,
)
Expand Down
2 changes: 1 addition & 1 deletion et_replay/comm/param_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import logging
import time
from dataclasses import dataclass
from typing import Any, Optional
from typing import Any

from torch.autograd.profiler import record_function

Expand Down
2 changes: 1 addition & 1 deletion et_replay/tools/comm_replay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
from torch.profiler import ProfilerActivity

try:
from param_bench.et_replay.vendor_internal.fb_internal import (
from et_replay.vendor_internal.fb_internal import (
get_fb_profiler_activities,
get_fb_profiler_trace_handler,
)
Expand Down
12 changes: 4 additions & 8 deletions et_replay/tools/et_replay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def __init__(self):
self.profile_step_label = "ProfilerStep#"

try:
from param_bench.et_replay.vendor_internal.fb_internal import (
from et_replay.vendor_internal.fb_internal import (
add_internal_parallel_nodes_parents,
)
except ImportError:
Expand Down Expand Up @@ -271,9 +271,7 @@ def initBench(self):
# Input et trace should be explicitly specified after --input.
if "://" in self.args.input:
try:
from param_bench.et_replay.vendor_internal.fb_internal import (
read_remote_trace,
)
from et_replay.vendor_internal.fb_internal import read_remote_trace
except ImportError:
logger.info("FB internals not present")
exit(1)
Expand All @@ -300,7 +298,7 @@ def initBench(self):
# Different processes should read different traces based on global_rank_id.
if "://" in self.args.trace_path:
try:
from param_bench.et_replay.vendor_internal.fb_internal import (
from et_replay.vendor_internal.fb_internal import (
read_remote_skip_node_file,
read_remote_trace,
)
Expand Down Expand Up @@ -1848,9 +1846,7 @@ def run_iter(iter):
end_time = datetime.now()

try:
from param_bench.et_replay.vendor_internal.fb_internal import (
generate_query_url,
)
from et_replay.vendor_internal.fb_internal import generate_query_url
except ImportError:
logger.info("FB internals not present")
else:
Expand Down
4 changes: 2 additions & 2 deletions et_replay/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
import logging
import os
import uuid
from typing import Any, Dict
from typing import Any

from et_replay import ExecutionTrace
from et_replay.execution_trace import ExecutionTrace


def get_tmp_trace_filename() -> str:
Expand Down
2 changes: 1 addition & 1 deletion train/comms/pt/commsTraceParser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import json

from et_replay import ExecutionTrace
from et_replay.execution_trace import ExecutionTrace

from param_bench.train.comms.pt import comms_utils
from param_bench.train.comms.pt.comms_utils import commsArgs
Expand Down