This repository was archived by the owner on Nov 2, 2020. It is now read-only.
Search functionality#116
Open
tevelee wants to merge 5 commits intofacebookarchive:masterfrom
tevelee:feature/search
Open
Search functionality#116tevelee wants to merge 5 commits intofacebookarchive:masterfrom tevelee:feature/search
tevelee wants to merge 5 commits intofacebookarchive:masterfrom
tevelee:feature/search
Conversation
Author
|
Hi @grp @sgl0v @johntmcintosh @callumboddy, Can somebody please review this feature? |
Author
|
I believe this PR is still valid. Can somebody take a look, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
The following changes introduce a basic search functionality in the tweaks UI as proposed in issue #115. Tweaks are searchable using a single search query on the category- and the collection lists as well.
Features
Technical considerations for the reviewer
Enhancements to consider